Skip to content

fix: preserve fetch stack traces #4778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcollina merged 1 commit into from
Jan 29, 2026
Merged

fix: preserve fetch stack traces #4778

mcollina merged 1 commit into from
Jan 29, 2026
+56 −12

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Jan 27, 2026

Summary

  • append caller stack traces for fetch errors without overwriting existing internal stacks
  • keep wrapper frames only when missing and avoid duplicate frames
  • relax stack trace tests to assert presence of internal fetch frames and caller context

Testing

  • npx borp -p "test/fetch/client-error-stack-trace.js"

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.25%. Comparing base (4b36fef) to head (8c9188f).

Files with missing lines Patch % Lines
index.js 92.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4778      +/-   ##
==========================================
- Coverage   93.25%   93.25%   -0.01%     
==========================================
  Files         109      109              
  Lines       34001    34023      +22     
==========================================
+ Hits        31708    31727      +19     
- Misses       2293     2296       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina merged commit 1edea72 into main Jan 29, 2026
35 of 37 checks passed
@mcollina mcollina deleted the fix-fetch-stack-trace-2331 branch January 29, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KhafraDev KhafraDev KhafraDev approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@atlowChemi atlowChemi Awaiting requested review from atlowChemi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcollina @codecov-commenter @KhafraDev